Cleanups to StochasticRoundingRNGState
#3922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D72183643 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 3, 2025
Summary: X-link: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Differential Revision: D72183643
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 3, 2025
Summary: X-link: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Differential Revision: D72183643
|
This pull request was exported from Phabricator. Differential Revision: D72183643 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 3, 2025
Summary: Pull Request resolved: pytorch#3922 X-link: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Differential Revision: D72183643
|
This pull request was exported from Phabricator. Differential Revision: D72183643 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 3, 2025
Summary: Pull Request resolved: pytorch#3922 X-link: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Differential Revision: D72183643
q10
force-pushed
the
export-D72183643
branch
2 times, most recently
from
992bf9f to
ba3e406
Compare
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 4, 2025
Summary: X-link: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Differential Revision: D72183643
|
This pull request was exported from Phabricator. Differential Revision: D72183643 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 4, 2025
Summary: Pull Request resolved: pytorch#3922 X-link: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Differential Revision: D72183643
|
This pull request was exported from Phabricator. Differential Revision: D72183643 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 4, 2025
Summary: Pull Request resolved: pytorch#3922 X-link: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Differential Revision: D72183643
q10
force-pushed
the
export-D72183643
branch
2 times, most recently
from
4f10f7d to
b813bc3
Compare
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 4, 2025
Summary: X-link: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Differential Revision: D72183643
|
This pull request was exported from Phabricator. Differential Revision: D72183643 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 4, 2025
Summary: X-link: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Differential Revision: D72183643
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 4, 2025
Summary: X-link: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Differential Revision: D72183643
|
This pull request was exported from Phabricator. Differential Revision: D72183643 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 4, 2025
Summary: Pull Request resolved: pytorch#3922 X-link: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Differential Revision: D72183643
|
This pull request was exported from Phabricator. Differential Revision: D72183643 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 4, 2025
Summary: Pull Request resolved: pytorch#3922 X-link: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Differential Revision: D72183643
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 4, 2025
Summary: X-link: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Differential Revision: D72183643
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 4, 2025
Summary: X-link: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Differential Revision: D72183643
|
This pull request was exported from Phabricator. Differential Revision: D72183643 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 4, 2025
Summary: Pull Request resolved: pytorch#3922 X-link: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Differential Revision: D72183643
|
This pull request was exported from Phabricator. Differential Revision: D72183643 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 5, 2025
Summary: Pull Request resolved: pytorch#3922 X-link: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Differential Revision: D72183643
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 5, 2025
Summary: X-link: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Differential Revision: D72183643
|
This pull request was exported from Phabricator. Differential Revision: D72183643 |
Summary: X-link: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Differential Revision: D72183643
|
This pull request was exported from Phabricator. Differential Revision: D72183643 |
|
This pull request has been merged in cb1ad0c. |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: X-link: pytorch#3922 Pull Request resolved: facebookresearch/FBGEMM#1010 - Simplify and remove redundant code with `StochasticRoundingRNGState` initialization and refactor the code to make it more maintainable. This follows up on the work in D72201618 Reviewed By: sryap Differential Revision: D72183643 fbshipit-source-id: adb4ec12686e69e0ffbe1a158110473a4c518736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: - Simplify and remove redundant code with
StochasticRoundingRNGStateinitialization and refactor the code to make it more maintainable. This follows up on the work in D72201618Differential Revision: D72183643