Skip to content

Conversation

donBarbos
Copy link
Contributor

PyPI | Github

it seems neither source code of lib nor the PR are being developed anymore (the last change in the code was 5 years ago and the PR about adding type stubs was sent 9 years ago)

@brianschubert
Copy link
Member

FYI appdirs was previously removed: #9884

@donBarbos donBarbos closed this Mar 23, 2025
@donBarbos
Copy link
Contributor Author

Sorry, I missed it :)

Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

pyppeteer (https://github.com/pyppeteer/pyppeteer)
+ pyppeteer/__init__.py:22: error: Argument 2 to "get" of "Mapping" has incompatible type "str | PathLike[str]"; expected "str"  [arg-type]

@AlexWaygood
Copy link
Member

(types-appdirs should still be installable from PyPI if you need those stubs! We just won't be updating them in typeshed anymore :-)

@donBarbos
Copy link
Contributor Author

thank you, i got it. but i was just looking for a reason to send PR 😄

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Mar 23, 2025

but i was just looking for a reason to send PR

I get what you're saying (and am grateful for several of your recent PRs to typeshed!), but note this is a somewhat dangerous path. For instance, I find that mindset leads me away from prioritising working on contributions that would maximise impact or maximise my personal learning. In general, I find it a good principle to prioritise contributions that you know at least one real life human will find real life helpful. This also makes sure we make good use of the time of real life human reviewers!

@donBarbos
Copy link
Contributor Author

ok thanks, i was trying to find a library without type hints and forgot to check issues in this repo, so i'll focus on the fact that many stubs are not completed now 👍

@donBarbos donBarbos deleted the add-appdirs branch September 27, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants