Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check config.ini is sorted with GitHub Actions #592

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Mar 4, 2025

Follow on from #591 where we discovered config.ini was no longer sorted.

This PR runs sort-ini.py on the CI and will fail if there was a change.

Here's an example failure: https://github.com/hugovk/planet/actions/runs/13658725429/job/38184489758

And an example pass: https://github.com/hugovk/planet/actions/runs/13658738341/job/38184533998


Optionally, we could enable https://pre-commit.ci/ on this repo and it will auto-update unsorted PRs.

@hugovk hugovk mentioned this pull request Mar 4, 2025
@malemburg
Copy link
Member

Optionally, we could enable https://pre-commit.ci/ on this repo and it will auto-update unsorted PRs.

I think this would be the better option. It would allow creating PRs using the Github UI only.

@hugovk
Copy link
Member Author

hugovk commented Mar 4, 2025

I meant to say:

Optionally, we could also enable https://pre-commit.ci/ on this repo and it will auto-update unsorted PRs.

It uses the .pre-commit-config.yaml config.

We could ditch the GitHub Actions file, but I think it's also useful if someone want to run it on their fork and they don't have pre-commit.ci enabled there.

In both cases, PRs can be created via the UI.

@malemburg
Copy link
Member

Ok, then let's do both 😃

Copy link
Member

@malemburg malemburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have enough expertise to actually do a real review of the suggested Github actions, but the general approach is a good one (and because the repo needs an approving review, I added one).

@hugovk
Copy link
Member Author

hugovk commented Mar 4, 2025

@python/organization-owners Please could you add this repo to https://pre-commit.ci?

Whilst we're here, if it's okay with @malemburg (anyone else I should ask?), I'll also volunteer for write permissions, then I can help with PRs like #587 :)

@malemburg
Copy link
Member

Whilst we're here, if it's okay with @malemburg (anyone else I should ask?), I'll also volunteer for write permissions, then I can help with PRs like #587 :)

Fine with me (I don't see a "Settings" button in the repo, though, so I guess I don't have permissions to give you write access).

@matrixise used to manage the Planet for a longer while. Any thoughts on this ?

@ewdurbin
Copy link
Member

ewdurbin commented Mar 5, 2025

@python/organization-owners Please could you add this repo to https://pre-commit.ci?

Done. https://results.pre-commit.ci/repo/github/24216135

Whilst we're here, if it's okay with @malemburg (anyone else I should ask?), I'll also volunteer for write permissions, then I can help with PRs like #587 :)

I've created a new @python/planet team and assigned the maintain role for this repo. @matrixise has been set as the maintainer of the team and can add existing users from the Python org. I've also added @malemburg and @hugovk as members of the team.

@malemburg
Copy link
Member

Thanks, @ewdurbin

@hugovk
Copy link
Member Author

hugovk commented Mar 5, 2025

Thanks all!

@hugovk hugovk merged commit d523ef6 into python:main Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants