Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 13: Add deadline of one week to second a vote of no confidence #4163

Merged
merged 4 commits into from
Dec 13, 2024
Merged

PEP 13: Add deadline of one week to second a vote of no confidence #4163

merged 4 commits into from
Dec 13, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Dec 10, 2024 •
edited
Loading

@hugovk hugovk requested a review from a team as a code owner December 10, 2024 13:16
hugovk
hugovk commented Dec 10, 2024
View reviewed changes
peps/pep-0013.rst Outdated Show resolved Hide resolved
hugovk
hugovk commented Dec 11, 2024
View reviewed changes
peps/pep-0013.rst Outdated Show resolved Hide resolved
gvanrossum
gvanrossum approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change look good, including update to change log for Bloc voting.

@hugovk hugovk merged commit c1c9094 into python:main Dec 13, 2024
5 checks passed
@hugovk hugovk deleted the pep13-one-week-seconding-deadline branch December 13, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradyunsg pradyunsg pradyunsg left review comments

@encukou encukou encukou left review comments

@warsaw warsaw warsaw left review comments

@mnoori1201 mnoori1201 mnoori1201 approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hugovk @warsaw @encukou @JelleZijlstra @gvanrossum @pradyunsg @mnoori1201