Error for invalid varargs and varkwargs to Any call #20324
+30
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
Surprised there were this many primer hits, but they seem right. I think error messages can be improved here, will land that after I land this |
This comment has been minimized.
This comment has been minimized.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pandas (https://github.com/pandas-dev/pandas)
+ pandas/io/excel/_xlsxwriter.py:260: error: Expected iterable as variadic argument [misc]
pandera (https://github.com/pandera-dev/pandera)
+ tests/pandas/test_extensions.py:57: error: Argument after ** must be a mapping, not "object" [arg-type]
+ tests/pandas/test_extensions.py:99: error: Argument after ** must be a mapping, not "object" [arg-type]
apprise (https://github.com/caronc/apprise)
+ apprise/config/base.py:807: error: Argument after ** must be a mapping, not "str" [arg-type]
xarray (https://github.com/pydata/xarray)
+ xarray/core/common.py: note: In member "squeeze" of class "DataWithCoords":
+ xarray/core/common.py:460: error: Keywords must be strings [misc]
+ xarray/core/dataset.py: note: In member "_stack_once" of class "Dataset":
+ xarray/core/dataset.py:5204: error: Keywords must be strings [misc]
openlibrary (https://github.com/internetarchive/openlibrary)
+ openlibrary/core/imports.py: note: In member "add_items" of class "Batch":
+ openlibrary/core/imports.py:131: error: Argument after ** must be a mapping, not "str | dict[Any, Any]" [arg-type]
|
sterliakov
reviewed
Nov 30, 2025
| self, args: list[Expression], arg_kinds: list[ArgKind], callee: Type, context: Context | ||
| ) -> tuple[Type, Type]: | ||
| arg_types = self.infer_arg_types_in_empty_context(args) | ||
| for arg_type, arg_kind in zip(arg_types, arg_kinds): |
Collaborator
There was a problem hiding this comment.
Maybe extract this into a helper? This loop is identical to one around L2516. Probably not a big deal, but would be saner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18783
See also #18207