Skip to content

Conversation

wyattscarpenter
Copy link
Contributor

This is a grammatical error (at least in American English, which I think this project is written in) because in the relevant sense the verb "allows" is transitive and needs to apply to a noun, not a verb.

More info, if desired:

https://english.stackexchange.com/questions/60271/grammatical-complements-for-allow

https://english.stackexchange.com/questions/85069/is-the-construction-it-allows-to-proper-english

(I don't know of any weighty publications who have taken this question on, so it's just a bunch of speakers, such as myself, opining.)

Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

AutoSplit (https://github.com/Toufool/AutoSplit)
-   File "/tmp/mypy_primer/mypy_old/venv/bin/mypy", line 7, in <module>
+   File "/tmp/mypy_primer/mypy_new/venv/bin/mypy", line 7, in <module>
-   File "/tmp/mypy_primer/mypy_old/venv/lib/python3.13/site-packages/mypy/__main__.py", line 15, in console_entry
+   File "/tmp/mypy_primer/mypy_new/venv/lib/python3.13/site-packages/mypy/__main__.py", line 15, in console_entry
-   File "/tmp/mypy_primer/mypy_old/venv/lib/python3.13/site-packages/mypy/main.py", line 127, in main
+   File "/tmp/mypy_primer/mypy_new/venv/lib/python3.13/site-packages/mypy/main.py", line 127, in main
-   File "/tmp/mypy_primer/mypy_old/venv/lib/python3.13/site-packages/mypy/main.py", line 211, in run_build
+   File "/tmp/mypy_primer/mypy_new/venv/lib/python3.13/site-packages/mypy/main.py", line 211, in run_build
-   File "/tmp/mypy_primer/mypy_old/venv/lib/python3.13/site-packages/mypy/build.py", line 196, in build
+   File "/tmp/mypy_primer/mypy_new/venv/lib/python3.13/site-packages/mypy/build.py", line 196, in build
-   File "/tmp/mypy_primer/mypy_old/venv/lib/python3.13/site-packages/mypy/build.py", line 272, in _build
+   File "/tmp/mypy_primer/mypy_new/venv/lib/python3.13/site-packages/mypy/build.py", line 272, in _build
-   File "/tmp/mypy_primer/mypy_old/venv/lib/python3.13/site-packages/mypy/build.py", line 2946, in dispatch
+   File "/tmp/mypy_primer/mypy_new/venv/lib/python3.13/site-packages/mypy/build.py", line 2946, in dispatch
-   File "/tmp/mypy_primer/mypy_old/venv/lib/python3.13/site-packages/mypy/build.py", line 3346, in process_graph
+   File "/tmp/mypy_primer/mypy_new/venv/lib/python3.13/site-packages/mypy/build.py", line 3346, in process_graph
-   File "/tmp/mypy_primer/mypy_old/venv/lib/python3.13/site-packages/mypy/build.py", line 3475, in process_stale_scc
+   File "/tmp/mypy_primer/mypy_new/venv/lib/python3.13/site-packages/mypy/build.py", line 3475, in process_stale_scc
-   File "/tmp/mypy_primer/mypy_old/venv/lib/python3.13/site-packages/mypy/build.py", line 2493, in write_cache
+   File "/tmp/mypy_primer/mypy_new/venv/lib/python3.13/site-packages/mypy/build.py", line 2493, in write_cache
-   File "/tmp/mypy_primer/mypy_old/venv/lib/python3.13/site-packages/mypy/cache.py", line 28, in __init__
+   File "/tmp/mypy_primer/mypy_new/venv/lib/python3.13/site-packages/mypy/cache.py", line 28, in __init__

@A5rocks
Copy link
Collaborator

A5rocks commented Sep 24, 2025

I think the project standard seems to be "the user" rather than 3rd person singular "one". Not that important but might as well if we're fixing the verbiage :^)

@wyattscarpenter
Copy link
Contributor Author

wyattscarpenter commented Sep 24, 2025

Ah, I see you are a verbiage aficionado as well!

We don't mention "the user" anywhere on the current command line page, so I resist the idea that this is much of a standard for user-facing documentation. In fact, by contrast the page has one instance of "one" in the relevant sense already:

For example, if one has the following files

Although both would work, and I would probably accept any GitHub-level "suggestions" I could easily click accept on, I do prefer "one" over "the user" as less clunky, strongly albeit arbitrarily.

@A5rocks
Copy link
Collaborator

A5rocks commented Sep 24, 2025

Oh alright; I was basing my comment off a quick code search of "the user" vs " one " but I gave up after several unrelated results for the second :P

(You use "the user" in #19904 /s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants