Add: refinement of ReadOnly TypedDict fields in subclasses#18704
Closed
ldeld wants to merge 1 commit intopython:masterfrom
Closed
Add: refinement of ReadOnly TypedDict fields in subclasses#18704ldeld wants to merge 1 commit intopython:masterfrom
ldeld wants to merge 1 commit intopython:masterfrom
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: django-stubs (https://github.com/typeddjango/django-stubs): 2.07x faster (51.1s -> 24.6s in a single noisy sample)
|
ilevkivskyi
reviewed
Feb 21, 2025
| require_bool_literal_argument, | ||
| ) | ||
| from mypy.state import state | ||
| from mypy.subtypes import is_subtype |
Member
There was a problem hiding this comment.
Unfortunately, it is not safe to call is_subtype() during semantic analysis (except in semanal_typeargs.py which is the last pass, but this is not helpful for you). Some types may not be fully analyzed and this will cause all kinds of weird behaviors.
This kind of checks can be only done during type-checking phase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7435
Adds the possibility to refine read-only keys in TypedDicts through inheritance.
The refinement is limited to read-only keys because refining mutable keys leads to unsafe edge cases (see #7435 (comment))
The rules are straight-forward:
@hauntsaninja, I saw you were open to receiving a PR for this. This is the first time I look at mypy's source code, so I apologize if the code is not up to standard! (I was particularly unsure if it is OK to modify failure messages.)