Add more known types for better generation with pybind11 #18269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
hamdanal
reviewed
Dec 21, 2024
Comment on lines
+263
to
+264
| "TypeIs", | ||
| "TypeGuard", |
There was a problem hiding this comment.
Are TypeIs, TypeGuard, Never and NoReturn common in c extensions? If they are not commonly used I think it is better to leave them out.
Comment on lines
+267
to
+268
| "os": ["PathLike"], | ||
| "pathlib": ["Path"], |
There was a problem hiding this comment.
If it is easy enough please add a test for things imported from modules other than typing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more known types for stubgenc when it is a c module.