Skip to content

Add clarification that contributors must authorize the Python CLA bot #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add clarification that contributors must authorize the Python CLA bot #1667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions getting-started/pull-request-lifecycle.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,8 @@ Here are the steps needed in order to sign the CLA:

2. When ``python-cla-bot`` comments on your pull request that commit
authors are required to sign a Contributor License Agreement, click
on the button in the comment to sign it. It's enough to log in through
GitHub. The process is automatic.
on the button in the comment to sign it. Simply log in to GitHub,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on the button in the comment to sign it. Simply log in to GitHub,
on the button in the comment to sign it. Log in to GitHub,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit odd now, originally it was through but now it is to? It is an SSO, you do not directly log into GitHub. I propose (combined with Mariatta's suggestion, since IIRC two from the same thread cannot be applied):

Suggested change
on the button in the comment to sign it. Simply log in to GitHub,
on the button in the comment to sign it. Log in with GitHub,

click "Authorize Python CLA Bot", and then click "Sign".

3. After signing, the comment by ``python-cla-bot`` will update to
indicate that "all commit authors signed the Contributor License
Expand Down
Loading