-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
gh-141376: Fix exported symbols #141377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-141376: Fix exported symbols #141377
Conversation
* _io module: add "_Py_" prefix to "spec" variables. For example, rename bufferedrandom_spec to _Py_bufferedrandom_spec. * typevarobject.c: add "static" to "spec" and "slots" variables. * import.c: add "static" to "pkgcontext" variable.
|
With this patch: diff --git a/Tools/build/smelly.py b/Tools/build/smelly.py
index 9a360412a73..0b694392583 100755
--- a/Tools/build/smelly.py
+++ b/Tools/build/smelly.py
@@ -37,7 +37,7 @@ def is_local_symbol_type(symtype):
# Ignore the initialized data section (d and D) and the BSS data
# section. For example, ignore "__bss_start (type: B)"
# and "_edata (type: D)".
- if symtype in "bBdD":
+ if symtype in "bB":
return True
return False
|
cmaloney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most modules don't need the extern PyType_Spec pieces that the _io module currently uses; 👍 for this change and I added to my I/O rework notes that it would be nice to reduce the need for these.
|
|
(The noGIL failure is a known issue, #120158.) |
Pyprefix #141376