Skip to content

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Nov 10, 2025

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
Copy link
Member

@StanFromIreland: Oh, there is now a merge conflict. Can you try to fix it?

@StanFromIreland
Copy link
Member Author

Done :-)

@vstinner vstinner merged commit f1330b3 into python:main Nov 12, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Nov 12, 2025
@StanFromIreland StanFromIreland deleted the Py_MATH branch November 12, 2025 16:38
@StanFromIreland
Copy link
Member Author

Thanks Victor and Sergey!

@vstinner
Copy link
Member

Merged, thanks.

@StanFromIreland
Copy link
Member Author

Do we want to backport? These constants all exist on all bug-fix branches.

@vstinner vstinner added the needs backport to 3.14 bugs and security fixes label Nov 12, 2025
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2025
@bedevere-app
Copy link

bedevere-app bot commented Nov 12, 2025

GH-141471 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 12, 2025
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Nov 12, 2025
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2025
@bedevere-app
Copy link

bedevere-app bot commented Nov 12, 2025

GH-141472 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 12, 2025
@vstinner
Copy link
Member

Do we want to backport? These constants all exist on all bug-fix branches.

Ok, I created backports to 3.13 and 3.14.

vstinner pushed a commit that referenced this pull request Nov 12, 2025
… (#141471)

gh-141004: Document `Py_MATH_{E, PI, TAU}` constants (GH-141373)
(cherry picked from commit f1330b3)

Co-authored-by: Stan Ulbrych <[email protected]>
vstinner pushed a commit that referenced this pull request Nov 12, 2025
… (#141472)

gh-141004: Document `Py_MATH_{E, PI, TAU}` constants (GH-141373)
(cherry picked from commit f1330b3)

Co-authored-by: Stan Ulbrych <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants