gh-126016: Fix flaky test by allowing the SIGINT return code #139219
Merged
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GH-139158, I added a test that sent
KeyboardInterrupt
to the main thread so it would interrupt_Py_Finalize
and shut down. There was a subtle race condition there:_thread._start_joinable_thread
._start_joinable_thread
finishes from Python's perspective, so it begins execution.a
, signaling to the parent process that it is ready and may send the interrupt signal._start_joinable_thread
.KeyboardInterrupt
before_Py_Finalize
is reached. Python returns -2, which fails the test.The simplest way to fix this is by allowing a return code of -2 (
-SIGINT
) in addition to 0.