-
-
Notifications
You must be signed in to change notification settings - Fork 33k
gh-137165: Standardized non-zero-padded date formatting for datetime.strftime
#139088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
datetime.strftime
datetime.strftime
!buildbot iOS |
This comment was marked as outdated.
This comment was marked as outdated.
The implementation looks reasonable, but this should also be covered in the documentation, along with the fact that the |
67ec54d
to
eb5c883
Compare
@mhsmith I adapted the tests for iOS and added documentation in the |
@StanFromIreland Made all changes |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
@mhsmith All done, but TSan seems to be stuck |
!buildbot Windows11.Refleaks Third time lucky! |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@mhsmith Fixed, lets test |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've started the refleaks tests, but I suggest you work out how to run them on your own machine rather than requiring a team member to rerun them on every commit. I don't know exactly how to do this, but it looks like it involves the -R
option of python -m test
. See the buildbot configuration for more details.
a949bb5
to
0d53ced
Compare
@mhsmith Thanks! I'm running them on my machine, I just thought they needed to be run here as well to make sure everything works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks much better. Just a few stylistic comments:
@mhsmith All done |
🤖 New build scheduled with the buildbot fleet by @mhsmith for commit 9212a5a 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139088%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pganssle: I think this is ready for final review.
Previously, using non-zero-padded directives (e.g.,
%-d
) instrftime
caused test failures on Windows and Android (x86_64), while other platforms worked as expected.This has been fixed by manually handling such specifiers on these platforms.
Corresponding tests have been added to strftime tests.
On Windows using non-zero-padded directives raised ValueError.
On Android (x86_64) dicrectives were not replaced:
