Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-128271: fix incorrect handling of negative read sizes in HTTPResponse.read() #128270

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+24 −1
Open

gh-128271: fix incorrect handling of negative read sizes in HTTPResponse.read() #128270

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
974f928
Fixed http read_chunked for amt with negative value
manushkin Dec 26, 2024
2685fe6
Fixed http read_chunked for amt with negative value
manushkin Dec 26, 2024
343a888
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 26, 2024
f082c53
Added test
manushkin Dec 26, 2024
2cd0ead
Improved test
manushkin Dec 26, 2024
48bec8a
Simple commit to change email for cpython-cla-bot
manushkin Dec 26, 2024
26b7b2e
Improved test
manushkin Dec 27, 2024
4cd1232
Improved test
manushkin Dec 27, 2024
e348cec
Improved case for reading not chunked data
manushkin Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/http/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,8 @@ def _get_chunk_left(self):

def _read_chunked(self, amt=None):
assert self.chunked != _UNKNOWN
if amt is not None and amt < 0:
amt = None
value = []
try:
while (chunk_left := self._get_chunk_left()) is not None:
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2024-12-26-11-00-03.gh-issue-128271.mCcw3B.rst
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to link to previous bug report #112064

Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix incorrect handling of negative read sizes in :meth:`HTTPResponse.read
<http.client.HTTPResponse.read>`. Patch by [email protected]
picnixz marked this conversation as resolved.
Show resolved Hide resolved
Loading