-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-96398: Purge Emscripten code from configure.ac #117836
gh-96398: Purge Emscripten code from configure.ac #117836
Conversation
See pythongh-113632 and python/peps#3612: Emscripten is no longer supported
This comment was marked as outdated.
This comment was marked as outdated.
cc. @corona10 |
What about this change? #117819 |
IMO that should remain. We want to filter emcc out in |
But this code is no reason to remain if we purge them no? |
emcc also defines |
Okay, so to filter out emcc, we need emcc :( Would you like to add a comment on that code to annotate that we do not support each according to PEP? |
Or to put it another way: to filter out emcc, we need to know how to identify it :)
We already have the switch in L1130. Did you think about a comment in the check that defines |
Alternatively, we can just keep this code; there is not a huge maintenance burden; a solution could be to add a comment above the lines that are proposed to be purged by this PR. |
I don't get why this code has to be removed right now. CPython is full of code specific to "unsupported" platforms such as MinGW or OpenBSD. There are CPython users using this build mode: build CPython for the browser. |
Yes, let's go with my suggestion from #117836 (comment). |
"CPython in the browser" is a top topic with https://pyodide.org/ and https://pyscript.net/ projects. |
See gh-113632 and python/peps#3612: Emscripten is no longer supported