bpo-35186: Remove "built with" comment in setup.py upload (GH-10414)

platform.dist() is deprecated and slated for removal in Python 3.8. The upload command itself should also not be used to upload to PyPI, but while it continues to exist it should not use deprecated functions.
python · Dec 17, 2018 · 4e80f5c · 4e80f5c
1 parent 2dfe351
commit 4e80f5c
Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/Lib/distutils/command/upload.py b/Lib/distutils/command/upload.py
@@ -121,14 +121,8 @@ def upload_file(self, command, pyversion, filename):
             'requires': meta.get_requires(),
             'obsoletes': meta.get_obsoletes(),
             }
-        comment = ''
-        if command == 'bdist_rpm':
-            dist, version, id = platform.dist()
-            if dist:
-                comment = 'built for %s %s' % (dist, version)
-        elif command == 'bdist_dumb':
-            comment = 'built for %s' % platform.platform(terse=1)
-        data['comment'] = comment
+
+        data['comment'] = ''
 
         if self.sign:
             data['gpg_signature'] = (os.path.basename(filename) + ".asc",

diff --git a/Misc/NEWS.d/next/Library/2018-11-08-14-22-29.bpo-35186.5m22Mj.rst b/Misc/NEWS.d/next/Library/2018-11-08-14-22-29.bpo-35186.5m22Mj.rst
@@ -0,0 +1,2 @@
+Removed the "built with" comment added when ``setup.py upload`` is used with
+either ``bdist_rpm`` or ``bdist_dumb``.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Removed the "built with" comment added when ``setup.py upload`` is used with
		either ``bdist_rpm`` or ``bdist_dumb``.