Skip to content

Add parameters to JsCode #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add parameters to JsCode #2123

wants to merge 1 commit into from
+50 −46

Conversation

hansthen
Copy link
Collaborator

@hansthen hansthen commented Apr 6, 2025

closes #2121

@hansthen hansthen requested a review from Conengmo April 7, 2025 05:57
@hansthen hansthen force-pushed the issue_2121_JsCode_params branch from 62db149 to a10241a Compare April 12, 2025 17:31
@hansthen hansthen requested a review from ocefpaf April 19, 2025 05:31
@hansthen hansthen marked this pull request as draft April 19, 2025 21:42
@hansthen
Copy link
Collaborator Author

I am making this a draft for now. I saw some movement on python to implement a new version of template strings, which uses a different format to specify parameters.

@ocefpaf
Copy link
Member

ocefpaf commented Apr 22, 2025

I am making this a draft for now. I saw some movement on python to implement a new version of template strings, which uses a different format to specify parameters.

Hehe. With t-strings, if we had enough time, we should re-write folium without jinja 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conengmo Conengmo

@ocefpaf ocefpaf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add template parameters to JsCode objects
2 participants
@hansthen @ocefpaf