Make DivIcon and CustomIcon work with the new Marker approach #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier we made this change for
MarkerandIcon(#2068), where theIcontemplate no longer adds itself to its parent. Instead, theMarkercontains code to add its icon to itself. This makes it so that an icon can be reused for multiple markers.At the time we didn't also apply this to
DivIconandCustomIcon. But it works for them in the same way and solves the same issue.This should close #744 and also close #1885.
TODO
This PR should fix the regression introduced by Fix icon when passing Marker to GeoJson #2086, where marker.add_child(icon) broke.
This PR needs some rigorous tests to make sure it works robustly for all cases, like passing icon as a parameter, or doing
marker.add_child(icon)oricon.add_to(marker).