Fix boolean return type consistency across validators #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix inconsistent boolean return types in domain validation regex check. - Changed re.match() result to bool() for consistent boolean return - Ensures both parts of the 'and' expression return proper booleans - Maintains type safety and consistency with @validator decorator expectations - Improves code reliability and predictability This addresses a logical inconsistency where re.search() was negated (returning bool) while re.match() returned a match object (truthy but not strictly boolean).
Wrap IPv4Address, IPv6Address, IPv4Network, and IPv6Network objects with bool() for consistent boolean return types. - Ensures all validators return proper booleans instead of truthy objects - Maintains type safety and consistency with @validator decorator expectations - Improves predictability and follows the documented return type signatures - Addresses inconsistent return types in IP validation functions
Wrap re.match() result with bool() for consistent boolean return type. - Ensures MAC address validator returns proper boolean instead of match object - Maintains consistency with other validators and @validator decorator expectations - Part of systematic fix for boolean return type inconsistencies across validators
Wrap UUID() object and re.match() result with bool() for consistent boolean return types. - Ensures UUID validator returns proper booleans instead of truthy objects - Maintains consistency with other validators and @validator decorator expectations - Part of systematic fix for boolean return type inconsistencies across validators
Wrap re.match() result with bool() for consistent boolean return type. - Ensures slug validator returns proper boolean instead of match object - Maintains consistency with other validators and @validator decorator expectations - Completes systematic fix for boolean return type inconsistencies across validators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Systematically fixes boolean return type inconsistencies across multiple validator functions.
Changes Made
re.match()result withbool()for consistent boolean returnIPv4Address,IPv6Address,IPv4Network,IPv6Networkobjects withbool()re.match()result withbool()UUID()object andre.match()result withbool()re.match()result withbool()Problem Fixed
Several validators were returning truthy objects (match objects, IP address objects) instead of strict boolean values, creating inconsistencies with the
@validatordecorator expectations and function signatures.Impact
Testing
All existing functionality preserved - changes only affect return type consistency, not validation logic.