Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent MockClock from mutating the current runner #3205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent MockClock from mutating the current runner #3205

wants to merge 1 commit into from

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Feb 10, 2025

Based on the issue @jc211 had on Gitter. You probably shouldn't be creating a MockClock and not using it, but this is a footgun.

@A5rocks
Copy link
Contributor Author

A5rocks commented Feb 11, 2025

I thought we were over dtls's smoke test timing out the macos pypy runner! For now I'll just rerun CI.

@A5rocks
Copy link
Contributor Author

A5rocks commented Mar 31, 2025 •
edited
Loading

I doubt this change will cause any issues, so if nobody objects I'll merge this before the next release (~3 weeks hopefully)

(this is a call for reviews!)

CoolCat467
CoolCat467 reviewed Mar 31, 2025
View reviewed changes
Copy link
Member

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering about where self._autojump_threshold gets set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikenerone mikenerone mikenerone approved these changes

@CoolCat467 CoolCat467 CoolCat467 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@A5rocks @mikenerone @CoolCat467