Skip to content

Feat/type definition #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Hoblovski
Copy link

Description

Using jedi's infer to support checking type definition.
The same approach is used by jedi-language-server.

This PR, combined with smheidrich's Goto Implementation PR, should fix issue 97.

Also added some unit tests.

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thank you!

@Hoblovski
Copy link
Author

Hoblovski commented May 13, 2025

Renamed plugin to *jedi_*type_definition, removed debug lines, fixed copyright lines.

Oops... Force push to fix the ruff errors.

@Hoblovski Hoblovski force-pushed the feat/type_definition branch from eb5fc48 to c516911 Compare May 13, 2025 13:02
@Hoblovski Hoblovski force-pushed the feat/type_definition branch from c516911 to 75f6234 Compare May 13, 2025 13:05
Hoblovski added a commit to cloudwego/abcoder that referenced this pull request May 15, 2025
Custom pylsp is based on [python-lsp-server](https://github.com/python-lsp/python-lsp-server), and plus the following pull requests:
1. semanticTokens/full: python-lsp/python-lsp-server#645
2. typeDefinition: python-lsp/python-lsp-server#533
Maybe also
3. implementation: python-lsp/python-lsp-server#644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to run lsp-goto-type-definition and lsp-goto-implementation.
2 participants