Python (code eval) & dependency version upgrades #246
Merged
+58
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb3
added
area: dependencies
jb3
force-pushed
the
jb3/3.14t-and-deps
branch
4 times, most recently
from
e67219b to
ebe1afe
Compare
Changes to multiprocessing in Python 3.14 make it more likely that the 5 PID limit is hit even with non-complicated uses of multiprocessing. We have enough compute to allocate more PIDs and safely know this will not affect the operation of other services (we have since migrated our databases and heavier processing applications onto other hosts).
jb3
force-pushed
the
jb3/3.14t-and-deps
branch
from
ebe1afe to
94f61f6
Compare
MarkKoz
requested changes
Oct 10, 2025
tests/test_nsjail.py
Outdated
| self.assertIn("Resource temporarily unavailable", result.stdout) | ||
| self.assertEqual(result.stderr, None) | ||
|
|
||
| self.nsjail.config.cgroup_pids_max = previous_pids_max |
There was a problem hiding this comment.
This should be in a finally block in case an assertion fails so other tests aren't impacted.
| object = "A" * 40_000_000 | ||
| time.sleep(0.5) | ||
| if __name__ == "__main__": |
There was a problem hiding this comment.
forkserver becoming the default start method means this is required (both forkserver and spawn will raise RuntimeError if the main module cannot be safely imported).
In 3.14, forkserver became the default for POSIX (Windows and macOS continue to use spawn), previously fork was used which did not require this.
https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods
| envar: "MKL_NUM_THREADS=5" | ||
| envar: "VECLIB_MAXIMUM_THREADS=5" | ||
| envar: "NUMEXPR_NUM_THREADS=5" | ||
| envar: "OMP_NUM_THREADS=15" |
There was a problem hiding this comment.
Never mind I read the commit message
This test case was being caught and nsjail was killing it, but not because of PID exhaustion but memory exhaustion. To ensure PID exhaustion is guarded against the PID count is now reduced to a level where nsjail will kill the process earlier before the memory limit.
jb3
force-pushed
the
jb3/3.14t-and-deps
branch
from
94f61f6 to
ad17dac
Compare
jb3
added a commit
to python-discord/bot
that referenced
this pull request
Oct 10, 2025
See python-discord/snekbox#246 for relevant snekbox changes
MarkKoz
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This does not change the version of Python used to run the snekbox API and
wrap around nsjail, just the versions that are available within the execution
environment.
This PR: