-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump redis version from <5 to <6 #460
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
+ Coverage 96.27% 96.47% +0.19%
==========================================
Files 11 11
Lines 1074 1078 +4
Branches 209 190 -19
==========================================
+ Hits 1034 1040 +6
Misses 19 19
+ Partials 21 19 -2 Continue to review full report in Codecov by Sentry.
|
May related with: #418 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #460 +/- ##
==========================================
- Coverage 96.27% 96.01% -0.27%
==========================================
Files 11 11
Lines 1074 1078 +4
Branches 209 190 -19
==========================================
+ Hits 1034 1035 +1
- Misses 19 21 +2
- Partials 21 22 +1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Is there any update on when this work might be considered for release? |
When are you planning to release with dependency updates? |
@chrisguidry @samuelcolvin 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks so much. |
Sorry for the delay in getting back to this 🙏. |
closes #458
Just tried to bump
redis
from<5
to<6
, and CI tests passed.redis 5 introduced some of incompatible API(
aclose
andclose
...) that made it difficult for users to change their code based on version 5, so I think bringing the version up to date it necessary.