Use function's keep_results configuration when storing failed jobs results #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
- Coverage 98.40% 98.03% -0.37%
==========================================
Files 11 11
Lines 1063 1071 +8
Branches 200 205 +5
==========================================
+ Hits 1046 1050 +4
- Misses 8 10 +2
- Partials 9 11 +2
Continue to review full report in Codecov by Sentry.
|
samuelcolvin
reviewed
Apr 1, 2024
| @@ -483,6 +483,7 @@ async def run_job(self, job_id: str, score: int) -> None: # noqa: C901 | |||
| abort_job = False | |||
|
|
|||
| function_name, enqueue_time_ms = '<unknown>', 0 | |||
| function: Optional[Union[Function, CronJob]] = None | |||
There was a problem hiding this comment.
Suggested change
| function: Optional[Union[Function, CronJob]] = None | |
| function: Union[Function, CronJob, None] = None |
Comment on lines
+520
to
+521
| with contextlib.suppress(KeyError): | ||
| function = self.functions[function_name] |
There was a problem hiding this comment.
Suggested change
| with contextlib.suppress(KeyError): | |
| function = self.functions[function_name] | |
| function = self.functions.get(function_name) |
| @@ -701,7 +703,9 @@ async def finish_job( | |||
| tr.delete(*delete_keys) # type: ignore[unused-coroutine] | |||
| await tr.execute() | |||
|
|
|||
| async def finish_failed_job(self, job_id: str, result_data: Optional[bytes]) -> None: | |||
| async def finish_failed_job( | |||
| self, job_id: str, result_data: Optional[bytes], function: Optional[Union[Function, CronJob]] | |||
There was a problem hiding this comment.
Suggested change
| self, job_id: str, result_data: Optional[bytes], function: Optional[Union[Function, CronJob]] | |
| self, job_id: str, result_data: Optional[bytes], function: Union[Function, CronJob, None] |
|
Agree, I think this looks good. 😊 |
|
Thanks for looking at this one! Any chance this can enter the v0.26.0b1 release? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a stab at using a function's (or cron job's) configuration for keeping the job results when the job fails.
I don't think this is a complete solution yet. There are a few cases where the job results are written to redis using the Worker's configuration because we can't get the Function in order to use it's config.
But maybe this is a situation where it's good enough to improve the situation for the most common situation?
Addresses #417
Relates to #416