-
Notifications
You must be signed in to change notification settings - Fork 267
feat(stylus): implement queryPriceFeed, priceFeedExists functions, clean tests #2849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+284
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logic - Change PriceFeedReturn from hex string to byte array ([u8; 32], U64, I32, I64, U64, I64, U64) - Update parse_price_feed_updates_internal to return Vec<PriceFeedReturn> instead of Vec<([u8; 32], PriceFeedReturn)> - Simplify parse_price_feed_updates_with_config by removing price_map and using direct indexing with find() - Simplify update_price_feeds_internal to avoid dual variable iteration and directly index structs - Update test data functions to use byte arrays from helper functions instead of hex strings - Add helper functions for different feed IDs used in multiple updates tests All tests pass successfully with these changes. Co-Authored-By: [email protected] <[email protected]>
…oStorage - Add price_id field as StorageFixedBytes<32> to PriceInfoStorage struct - Rename PriceInfoStorage to PriceFeedStorage for consistency - Update import statement and storage map declaration in lib.rs - Update update_price_feeds_internal to populate price_id field when storing price data - All tests pass with structural changes Co-Authored-By: [email protected] <[email protected]>
…turn type and the overall price feed return that will be given from the query function
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ali-behjati
approved these changes
Jul 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the queryPriceFeed and priceFeedExists functions. It also cleans up a lot of the testing logic, which was pretty messy to this point,
How has this been tested?