fix: ready endpoint already checks for fully hydrated cache #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: Tejas Badadare <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
Co-Authored-By: Tejas Badadare <[email protected]>
Co-Authored-By: Tejas Badadare <[email protected]>
Co-Authored-By: Tejas Badadare <[email protected]>
Co-Authored-By: Tejas Badadare <[email protected]>
Co-Authored-By: Tejas Badadare <[email protected]>
Comment on lines
279
to
282
| async fn is_cache_ready(&self) -> bool { | ||
| let message_cache = self.into().message_cache.read().await; | ||
| !message_cache.is_empty() | ||
| } |
There was a problem hiding this comment.
The cache should be considered "ready" if it's full, not just if it's non-empty. See the store_accumulator_messages() impl for an example of checking if the cache is full.
Co-Authored-By: Tejas Badadare <[email protected]>
| @@ -274,6 +275,14 @@ where | |||
| let cache = self.into().wormhole_merkle_state_cache.read().await; | |||
| Ok(cache.get(&slot).cloned()) | |||
| } | |||
|
|
|||
| /// | |||
There was a problem hiding this comment.
you forgot to finish this docstring
Co-Authored-By: Tejas Badadare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add is_ready() Method to Cache Trait and Update Ready Endpoint
Description
This PR updates the Hermes
/readyendpoint to return OK only when the cache is fully hydrated by:is_ready()method to theCachetrait that checks if the cache contains sufficient data to serve requests/readyendpoint to check both the aggregate readiness and cache readinessThe cache is now considered fully hydrated when all of the following conditions are met:
has_completed_recently: The latest completed update is recent (within the staleness threshold)is_not_behind: The latest completed slot isn't too far behind the latest observed slotis_metadata_loaded: Price feeds metadata is not emptyCache::is_ready()method)Link to Devin run
https://app.devin.ai/sessions/7467a93d13ab41adb52d38f5d6404e21
Requested by
Tejas Badadare ([email protected])