chore: Bump Rust version to 1.86.0 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-bahjati
reviewed
Apr 14, 2025
| @@ -27,6 +27,7 @@ pyth-sdk = "0.8.0" | |||
| pyth-sdk-solana = "0.10.4" | |||
| solana-account-decoder = "1.18.8" | |||
| solana-client = "1.18.8" | |||
| solana-pubkey = "2.3.0" | |||
There was a problem hiding this comment.
hmmm it's strange that this was needed. can you explain a bit?
There was a problem hiding this comment.
So pyth-sdk-solana uses the solana v2 sdk but agent itself still uses v1. As best I can tell a newer Rust version changed how imports are handled. The ideal solution is to bump forward the solana sdk totally but for now I wanted to make minimum changes.
ali-bahjati
approved these changes
Apr 14, 2025
merolish
force-pushed
the
mike/bump-1.86.0
branch
from
79ec257 to
8c8a20c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to use newer versions of crates was choking on the Rust version so I wanted to try moving this forward. Unfortunately there are some solana version mismatches until we can move those forward to version 2.