Warn when event loop fixture is requested explicitly in async functions #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icitly requested by a coroutine or an async fixture. Signed-off-by: Michael Seifert <[email protected]>
seifertm
force-pushed
the
warn-when-event-loop-fixture-is-requested-explicitly-in-async-functions
branch
from
f3acd72 to
5b84dd2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #648 +/- ##
==========================================
- Coverage 94.23% 94.08% -0.15%
==========================================
Files 2 2
Lines 399 406 +7
Branches 85 87 +2
==========================================
+ Hits 376 382 +6
Misses 14 14
- Partials 9 10 +1
☔ View full report in Codecov by Sentry. |
seifertm
deleted the
warn-when-event-loop-fixture-is-requested-explicitly-in-async-functions
branch
seifertm
restored the
warn-when-event-loop-fixture-is-requested-explicitly-in-async-functions
branch
seifertm
deleted the
warn-when-event-loop-fixture-is-requested-explicitly-in-async-functions
branch
20 tasks
carlsmedstad
added a commit
to carlsmedstad/aiogram
that referenced
this pull request
Sep 27, 2024
Introduced in pytest-asyncio in: pytest-dev/pytest-asyncio#648
carlsmedstad
added a commit
to carlsmedstad/aiogram
that referenced
this pull request
Sep 27, 2024
Introduced in pytest-asyncio in: pytest-dev/pytest-asyncio#648
JrooTJunior
pushed a commit
to aiogram/aiogram
that referenced
this pull request
Sep 27, 2024
Introduced in pytest-asyncio in: pytest-dev/pytest-asyncio#648
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #638