feat: support le normalization in prom 2 and 3
#1619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometheus 3 introduces normalization of `le` label values for classic histogram to improve consistency across different ingestion methods. More details can be found in the [Prometheus 2 to 3 migration guide][1]. This commit enables a seamless transition for users migrating from Prometheus 2 to Prometheus 3 by changing the `le` match behavior to a regular expression that matches both normalized and non-normalized `le` values. This ensures that rules generated by Pyrra continue to function correctly during and after the migration process. [1]: https://prometheus.io/docs/prometheus/latest/migration/#le-and-quantile-label-values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus 3 introduces normalization of
lelabel values for classic histogram to improve consistency across different ingestion methods. More details can be found in the Prometheus 2 to 3 migration guide. This commit enables a seamless transition for users migrating from Prometheus 2 to Prometheus 3 by changing thelematch behavior to a regular expression that matches both normalized and non-normalizedlevalues. This ensures that rules generated by Pyrra continue to function correctly during and after the migration process.fixes #1611