Optimize SLO performance with subquery-based calculations #1607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
approved these changes
Oct 24, 2025
metalmatze
force-pushed
the
improve-slo-performance-with-subqueries
branch
from
3cc0bee to
b8985c5
Compare
metalmatze
added a commit
to metalmatze/kube-prometheus
that referenced
this pull request
Nov 4, 2025
Introduce subquery-based calculations for improved performance while maintaining ~99% accuracy. This adds a new PerformanceOverAccuracy option that, when enabled, uses Prometheus subqueries with 5-minute step intervals to reduce query complexity and improve performance. Changes: - Add PerformanceOverAccuracy field to ServiceLevelObjective spec - Implement subquery expression handling in PromQL replacer - Add LessAccurate field to track optimization state in SLO objects This optimization sacrifices minimal accuracy for significant performance gains in resource-intensive SLO calculations. Closes #1440
- Rename LessAccurate to PerformanceOverAccuracy for consistency with the public API - Add proper field alignment in Objective struct initialization - Update all references throughout the codebase
metalmatze
force-pushed
the
improve-slo-performance-with-subqueries
branch
from
b8985c5 to
01b5ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce subquery-based calculations for improved performance while maintaining ~99% accuracy. This adds a new PerformanceOverAccuracy option that, when enabled, uses Prometheus subqueries with 5-minute step intervals to reduce query complexity and improve performance.
Changes
Closes #1440