Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Symbolic links in debug mode #235

Merged
merged 8 commits into from
Feb 25, 2024

Conversation

Buckram123
Copy link
Contributor

@Buckram123 Buckram123 commented Feb 22, 2024

Closes #234

This PR aims to allow reading symlinks in debug mode. Note that it creates issue by allowing reading symlink outside of embedded folder, which can be easily fixed by rust-lang/rust#92750

Run the test with

cargo test include_symlink --features include-exclude

@Buckram123 Buckram123 marked this pull request as ready for review February 24, 2024 12:56
@Buckram123
Copy link
Contributor Author

Hey @pyrossh found a fix for it! Deleted confusing PR message, sorry if you managed to receive it

@pyrossh pyrossh merged commit 02469a4 into pyrossh:master Feb 25, 2024
@pyrossh
Copy link
Owner

pyrossh commented Feb 25, 2024

LGTM. Thanks @Buckram123.

@Buckram123 Buckram123 deleted the symlinks-does-not-work-in-debug branch February 26, 2024 07:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to read symbolic link in debug mode
2 participants