Skip to content

Conversation

Wurschdhaud
Copy link
Contributor

Description

See title. Reference discussion:
#2811 (comment)

tested startup and few commands in both 2711 and 342.


Checklist

Before submitting your pull request, ensure the following requirements are met:

  • Code follows the PEP 8 style guide.
  • Code has been formatted with Black using the command:
    pipenv run black {source_file_or_directory}
  • Changes are tested and verified to work as expected.

Related Issues

If applicable, link the issues resolved by this pull request:

  • Resolves #[issue number]

Additional Notes

The (quite outdated) urllib3 has its own six.py package bundled - is it worth it to update that (or the whole lib?) to the last version supporting 342 as well? What are risks/downsides?


Thank you for contributing to pyRevit! 🎉

Copy link
Contributor

devloai bot commented Sep 27, 2025

Unable to perform a code review. You have run out of credits 😔
Please upgrade your plan or buy additional credits from the subscription page.

@jmcouffin jmcouffin added the Misc Compatibility Compatibility issue with other third-party addons [class->Updated #{number}: {title}] label Sep 28, 2025
Copy link
Contributor

@sanzoghenzo sanzoghenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmcouffin jmcouffin merged commit 7f2dc14 into pyrevitlabs:develop Sep 28, 2025
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 5.2.0.25271+1719-wip

@Wurschdhaud Wurschdhaud deleted the update-six branch September 28, 2025 17:43
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2003-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2012-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2017-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2149-wip

Copy link
Contributor

github-actions bot commented Oct 1, 2025

📦 New work-in-progress (wip) builds are available for 5.2.0.25274+1734-wip

Copy link
Contributor

github-actions bot commented Oct 4, 2025

📦 New work-in-progress (wip) builds are available for 5.2.0.25277+1425-wip

Copy link
Contributor

github-actions bot commented Oct 4, 2025

📦 New work-in-progress (wip) builds are available for 5.2.0.25277+1427-wip

Copy link
Contributor

github-actions bot commented Oct 6, 2025

📦 New work-in-progress (wip) builds are available for 5.2.0.25279+2157-wip

Copy link
Contributor

github-actions bot commented Oct 7, 2025

📦 New work-in-progress (wip) builds are available for 5.2.0.25280+0218-wip

Copy link
Contributor

github-actions bot commented Oct 7, 2025

📦 New work-in-progress (wip) builds are available for 5.2.0.25280+1054-wip

Copy link
Contributor

github-actions bot commented Oct 7, 2025

📦 New work-in-progress (wip) builds are available for 5.2.0.25280+1057-wip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Misc Compatibility Compatibility issue with other third-party addons [class->Updated #{number}: {title}]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants