Skip to content

Conversation

Denver-22
Copy link
Contributor

  • Dictionary updated for new versions of Revit Server.
  • Added support for non-ASCII characters in folder names on Revit Server.

Tested on Revit Server 2023 and folders with Cyrillic names.

- Dictionary updated for new versions of Revit Server.
- Added support for non-ASCII characters in folder names on Revit Server.
Copy link
Contributor

@devloai devloai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary:

• Adds support for Revit Server versions 2019-2026 by extending the sroots dictionary
• Implements UTF-8 URL encoding for non-ASCII characters in folder names using urllib.quote()
• Adds proper UTF-8 encoding header for IronPython compatibility
• Tested on Revit Server 2023 with Cyrillic folder names

Review Summary:

The implementation correctly addresses the stated requirements. The UTF-8 encoding header is appropriate for IronPython, the version dictionary extension follows the established pattern, and the URL encoding implementation using urllib.quote() should properly handle non-ASCII characters in Revit Server paths. The approach aligns with IronPython 2.7.12 capabilities and Revit Server's API structure using pipe separators.

Follow-up suggestions:

@devloai validate the 2025/2026 version support against actual server deployments when available

@jmcouffin jmcouffin added the Tools Issues related to pyRevit commands [subsystem] label Sep 26, 2025
@jmcouffin jmcouffin merged commit de91ecb into pyrevitlabs:develop Sep 26, 2025
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1436-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1822-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 5.2.0.25271+1719-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2003-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2012-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2017-wip

Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2149-wip

Copy link
Contributor

github-actions bot commented Oct 1, 2025

📦 New work-in-progress (wip) builds are available for 5.2.0.25274+1734-wip

Copy link
Contributor

github-actions bot commented Oct 4, 2025

📦 New work-in-progress (wip) builds are available for 5.2.0.25277+1425-wip

Copy link
Contributor

github-actions bot commented Oct 4, 2025

📦 New work-in-progress (wip) builds are available for 5.2.0.25277+1427-wip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools Issues related to pyRevit commands [subsystem]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants