-
-
Notifications
You must be signed in to change notification settings - Fork 393
Update pyrevitlib\rpws\server.py #2812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Dictionary updated for new versions of Revit Server. - Added support for non-ASCII characters in folder names on Revit Server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary:
• Adds support for Revit Server versions 2019-2026 by extending the sroots
dictionary
• Implements UTF-8 URL encoding for non-ASCII characters in folder names using urllib.quote()
• Adds proper UTF-8 encoding header for IronPython compatibility
• Tested on Revit Server 2023 with Cyrillic folder names
Review Summary:
The implementation correctly addresses the stated requirements. The UTF-8 encoding header is appropriate for IronPython, the version dictionary extension follows the established pattern, and the URL encoding implementation using urllib.quote()
should properly handle non-ASCII characters in Revit Server paths. The approach aligns with IronPython 2.7.12 capabilities and Revit Server's API structure using pipe separators.
Follow-up suggestions:
@devloai validate the 2025/2026 version support against actual server deployments when available
📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1436-wip |
📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1822-wip |
📦 New work-in-progress (wip) builds are available for 5.2.0.25271+1719-wip |
📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2003-wip |
📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2012-wip |
📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2017-wip |
📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2149-wip |
📦 New work-in-progress (wip) builds are available for 5.2.0.25274+1734-wip |
📦 New work-in-progress (wip) builds are available for 5.2.0.25277+1425-wip |
📦 New work-in-progress (wip) builds are available for 5.2.0.25277+1427-wip |
Tested on Revit Server 2023 and folders with Cyrillic names.