Skip to content

PY3 compatibility for itertools #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2025
Merged

PY3 compatibility for itertools #2811

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30005e7
PY3 compatibility for itertools
Wurschdhaud Sep 23, 2025
62eaf5d
add flush for print_md, cleanup zip_longest
Wurschdhaud Sep 24, 2025
ad8a199
Merge branch 'pyrevitlabs:develop' into develop
Wurschdhaud Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions pyrevitlib/pyrevit/output/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,12 @@

from __future__ import print_function
import os.path as op
import itertools
import sys
from pyrevit.compat import PY2, PY3
if PY2:
from itertools import izip_longest as zip_longest
elif PY3:
from itertools import zip_longest

from pyrevit import HOST_APP, EXEC_PARAMS
from pyrevit import framework
Expand Down Expand Up @@ -543,6 +548,8 @@ def print_md(md_str):
markdown_html = markdown_html.replace('\n', '').replace('\r', '')
html_code = coreutils.prepare_html_str(markdown_html)
print(html_code, end="")
if PY3:
sys.stdout.flush()

def print_table(self, table_data, columns=None, formats=None,
title='', last_line_style=''):
Expand Down Expand Up @@ -579,7 +586,6 @@ def print_table(self, table_data, columns=None, formats=None,
self.add_style('tr:last-child {{ {style} }}'
.format(style=last_line_style))

zipper = itertools.izip_longest #pylint: disable=E1101
adjust_base_col = '|'
adjust_extra_col = ':---|'
base_col = '|'
Expand All @@ -591,7 +597,7 @@ def print_table(self, table_data, columns=None, formats=None,
header = ''
if columns:
header = base_col
for idx, col_name in zipper(range(max_col), columns, fillvalue=''): #pylint: disable=W0612
for idx, col_name in zip_longest(range(max_col), columns, fillvalue=''): #pylint: disable=W0612
header += extra_col.format(data=col_name)

header += '\n'
Expand All @@ -606,7 +612,7 @@ def print_table(self, table_data, columns=None, formats=None,
for entry in table_data:
row = base_col
for idx, attrib, attr_format \
in zipper(range(max_col), entry, formats, fillvalue=''):
in zip_longest(range(max_col), entry, formats, fillvalue=''):
if attr_format:
value = attr_format.format(attrib)
else:
Expand Down