Skip to content

Fix SelectFromList retrieving behaviour #2806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2025
Merged

Fix SelectFromList retrieving behaviour #2806

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8808b71
fix : add _get_all_ctx() method to retrieve checked items from all co…
MohamedAsli Sep 15, 2025
84d6974
turn get_all_ctx into a generator
MohamedAsli Sep 23, 2025
594a909
Merge branch 'develop' into selectfromlist-fix
MohamedAsli Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions pyrevitlib/pyrevit/forms/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,6 +1016,22 @@ def _get_active_ctx(self):
else:
return self._context

def _get_all_ctx(self):
"""Get all context items across all groups"""
ctx = self._context
if ctx is None:
return

if isinstance(ctx, dict):
for group_items in ctx.values():
for item in group_items:
yield item
elif isinstance(ctx, (list, tuple, set)):
for item in ctx:
yield item
else:
yield ctx

def _list_options(self, option_filter=None):
if option_filter:
self.checkall_b.Content = "Check"
Expand Down Expand Up @@ -1062,12 +1078,12 @@ def _unwrap_options(options):
def _get_options(self):
if self.multiselect:
if self.return_all:
return [x for x in self._get_active_ctx()]
return list(self._get_all_ctx())
else:
return self._unwrap_options(
[
x
for x in self._get_active_ctx()
for x in self._get_all_ctx()
if x.state or x in self.list_lb.SelectedItems
]
)
Expand Down