Update PR

tests/common/db/packaging.py

@@ -120,8 +120,7 @@ class Meta:
         lambda o: hashlib.blake2b(o.filename.encode("utf8"), digest_size=32).hexdigest()
     )
     upload_time = factory.Faker(
-        "date_time_between_dates",
-        datetime_start=datetime.datetime(2008, 1, 1),
+        "date_time_between_dates", datetime_start=datetime.datetime(2008, 1, 1)
     )
     path = factory.LazyAttribute(
         lambda o: "/".join(

tests/unit/forklift/test_legacy.py

@@ -43,6 +43,7 @@
 from warehouse.events.tags import EventTag
 from warehouse.forklift import legacy, metadata
 from warehouse.macaroons import IMacaroonService, caveats, security_policy
+from warehouse.metrics import IMetricsService
 from warehouse.oidc.interfaces import SignedClaims
 from warehouse.oidc.utils import PublisherTokenContext
 from warehouse.packaging.interfaces import IFileStorage, IProjectService

tests/unit/legacy/api/test_json.py

@@ -118,13 +118,6 @@ def test_all_non_prereleases_yanked(self, monkeypatch, db_request):
         db_request.matchdict = {"name": project.normalized_name}
         assert json.latest_release_factory(db_request) == release
 
-    def test_with_unpublished(self, db_request):
-        project = ProjectFactory.create()
-        release = ReleaseFactory.create(project=project, version="1.0")
-        ReleaseFactory.create(project=project, version="2.0", published=False)
-        db_request.matchdict = {"name": project.normalized_name}
-        assert json.latest_release_factory(db_request) == release
-
     def test_project_quarantined(self, monkeypatch, db_request):
         project = ProjectFactory.create(
             lifecycle_status=LifecycleStatus.QuarantineEnter
@@ -164,6 +157,7 @@ def test_normalizing_redirects(self, db_request):
     def test_renders(self, pyramid_config, db_request, db_session):
         project = ProjectFactory.create(has_docs=True)
         description_content_type = "text/x-rst"
+        print("NOJ")
         url = "/the/fake/url/"
         project_urls = [
             "url," + url,

tests/unit/packaging/test_views.py

@@ -135,19 +135,6 @@ def test_only_yanked_release(self, monkeypatch, db_request):
         assert resp is response
         assert release_detail.calls == [pretend.call(release, db_request)]
 
-    def test_with_unpublished(self, monkeypatch, db_request):
-        project = ProjectFactory.create()
-        release = ReleaseFactory.create(project=project, version="1.0")
-        ReleaseFactory.create(project=project, version="1.1", published=False)
-
-        response = pretend.stub()
-        release_detail = pretend.call_recorder(lambda ctx, request: response)
-        monkeypatch.setattr(views, "release_detail", release_detail)
-
-        resp = views.project_detail(project, db_request)
-        assert resp is response
-        assert release_detail.calls == [pretend.call(release, db_request)]
-
 
 class TestReleaseDetail:
     def test_normalizing_name_redirects(self, db_request):

warehouse/forklift/legacy.py

@@ -659,6 +659,7 @@ def file_upload(request):
                 ]
             ),
         )
+
     # Ensure that we have file data in the request.
     if "content" not in request.POST:
         request.metrics.increment("warehouse.upload.failed", tags=["reason:no-file"])

warehouse/legacy/api/json.py

@@ -62,10 +62,7 @@ def _json_data(request, project, release, *, all_releases):
             )
         )
         .outerjoin(File)
-        .filter(
-            Release.project == project,
-            Release.published.is_(True),
-        )
+        .filter(Release.project == project)
     )
 
     # If we're not looking for all_releases, then we'll filter this further
@@ -209,8 +206,7 @@ def latest_release_factory(request):
             .filter(
                 Project.lifecycle_status.is_distinct_from(
                     LifecycleStatus.QuarantineEnter
-                ),
-                Release.published.is_(True),
+                )
             )
             .order_by(
                 Release.yanked.asc(),

warehouse/packaging/utils.py

@@ -53,11 +53,9 @@ def _simple_detail(project, request):
         .join(Release)
         .filter(Release.project == project)
         # Exclude projects that are in the `quarantine-enter` lifecycle status.
-        # And exclude un-published releases from the index
         .join(Project)
         .filter(
-            Project.lifecycle_status.is_distinct_from(LifecycleStatus.QuarantineEnter),
-            Release.published.is_(True),
+            Project.lifecycle_status.is_distinct_from(LifecycleStatus.QuarantineEnter)
         )
         .all(),
         key=lambda f: (packaging_legacy.version.parse(f.release.version), f.filename),

warehouse/packaging/views.py

@@ -179,10 +179,7 @@ def project_detail(project, request):
     try:
         release = (
             request.db.query(Release)
-            .filter(
-                Release.project == project,
-                Release.published.is_(True),
-            )
+            .filter(Release.project == project)
             .order_by(
                 Release.yanked,
                 Release.is_prerelease.nullslast(),