Skip to content

Commit f4161f6

Browse files
committed
Change to a boolean field
1 parent 60f4a01 commit f4161f6

File tree

8 files changed

+113
-107
lines changed

8 files changed

+113
-107
lines changed

tests/common/db/packaging.py

-3
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,6 @@ class Meta:
100100

101101
uploader = factory.SubFactory(UserFactory)
102102
description = factory.SubFactory(DescriptionFactory)
103-
published = factory.Faker(
104-
"date_time_between_dates", datetime_start=datetime.datetime(2008, 1, 1)
105-
)
106103

107104

108105
class FileFactory(WarehouseFactory):

tests/unit/forklift/test_legacy.py

+1
Original file line numberDiff line numberDiff line change
@@ -3613,6 +3613,7 @@ def test_upload_succeeds_creates_release(
36133613
else None
36143614
),
36153615
"uploaded_via_trusted_publisher": not test_with_user,
3616+
"published": True,
36163617
}
36173618

36183619
fileadd_event = {

tests/unit/packaging/test_views.py

+1-6
Original file line numberDiff line numberDiff line change
@@ -326,12 +326,7 @@ def test_long_singleline_license(self, db_request):
326326

327327
def test_created_with_published(self, db_request):
328328
release = ReleaseFactory.create()
329-
assert release.published > datetime(year=2008, month=1, day=1)
330-
331-
def test_without_published_date(self, db_request):
332-
release = ReleaseFactory.create(published=None)
333-
db_request.db.flush()
334-
assert release.published is None
329+
assert release.published is True
335330

336331

337332
class TestReportMalwareButton:

warehouse/forklift/legacy.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import zipfile
2020

2121
from cgi import FieldStorage
22-
from datetime import datetime
2322

2423
import packaging.requirements
2524
import packaging.specifiers
@@ -903,7 +902,6 @@ def file_upload(request):
903902
},
904903
uploader=request.user if request.user else None,
905904
uploaded_via=request.user_agent,
906-
published=datetime.now(),
907905
)
908906
request.db.add(release)
909907
is_new_release = True
@@ -934,6 +932,7 @@ def file_upload(request):
934932
else None
935933
),
936934
"uploaded_via_trusted_publisher": bool(request.oidc_publisher),
935+
"published": True,
937936
},
938937
)
939938

0 commit comments

Comments
 (0)