Add a default value for Release.published field.

Author: DarkaMaul

tests/common/db/packaging.py

@@ -123,7 +123,8 @@ class Meta:
         lambda o: hashlib.blake2b(o.filename.encode("utf8"), digest_size=32).hexdigest()
     )
     upload_time = factory.Faker(
-        "date_time_between_dates", datetime_start=datetime.datetime(2008, 1, 1)
+        "date_time_between_dates",
+        datetime_start=datetime.datetime(2008, 1, 1),
     )
     path = factory.LazyAttribute(
         lambda o: "/".join(

tests/unit/packaging/test_views.py

@@ -9,6 +9,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+from datetime import datetime
 
 import pretend
 import pytest
@@ -323,6 +324,15 @@ def test_long_singleline_license(self, db_request):
             "characters, it's really so lo..."
         )
 
+    def test_created_with_published(self, db_request):
+        release = ReleaseFactory.create()
+        assert release.published > datetime(year=2008, month=1, day=1)
+
+    def test_without_published_date(self, db_request):
+        release = ReleaseFactory.create(published=None)
+        db_request.db.flush()
+        assert release.published is None
+
 
 class TestReportMalwareButton:
     def test_report_malware_button(self):

warehouse/forklift/legacy.py

@@ -19,6 +19,7 @@
 import zipfile
 
 from cgi import FieldStorage
+from datetime import datetime
 
 import packaging.requirements
 import packaging.specifiers
@@ -902,6 +903,7 @@ def file_upload(request):
             },
             uploader=request.user if request.user else None,
             uploaded_via=request.user_agent,
+            published=datetime.now(),
         )
         request.db.add(release)
         is_new_release = True

warehouse/migrations/versions/3e7bf3217166_add_published_in_release.py

@@ -28,9 +28,7 @@
 def upgrade():
     op.add_column(
         "releases",
-        sa.Column(
-            "published", sa.DateTime(), server_default=sa.text("now()"), nullable=True
-        ),
+        sa.Column("published", sa.DateTime(), nullable=True),
     )
 
     op.execute(

warehouse/packaging/models.py

@@ -11,6 +11,7 @@
 # limitations under the License.
 from __future__ import annotations
 
+import datetime
 import enum
 import typing
 
@@ -612,7 +613,7 @@ def __table_args__(cls):  # noqa
     _pypi_ordering: Mapped[int | None]
     requires_python: Mapped[str | None] = mapped_column(Text)
     created: Mapped[datetime_now] = mapped_column()
-    published: Mapped[datetime_now | None]
+    published: Mapped[datetime.datetime | None]
 
     description_id: Mapped[UUID] = mapped_column(
         ForeignKey("release_descriptions.id", onupdate="CASCADE", ondelete="CASCADE"),