Skip to content

Backport bugfix for wheel naming for Python 3.8 #4879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Mar 11, 2025

Summary of changes

Closes #4877

Pull Request Checklist

@jaraco
Copy link
Member Author

jaraco commented Mar 11, 2025

Looks like I got something wrong in the cherry pick conflict resolution.

@jaraco
Copy link
Member Author

jaraco commented Mar 11, 2025

Annoyingly, tests no longer pass on v75.3.0. There are lots of ruff failures, presumably due to evolution of ruff.

Also, there are some DID NOT WARN failures due to now past due deprecations coming active.

FAILED setuptools/config/expand.py::ruff - pytest_ruff.RuffError: setuptools/config/expand.py:34:1: UP035 [*] Import from `collections.abc` instead: `Iterable`, `Iterator`, `Mapping`
FAILED setuptools/_importlib.py::ruff - pytest_ruff.RuffError: setuptools/_importlib.py:9:4: UP036 Version block is outdated for minimum Python version
FAILED setuptools/config/pyprojecttoml.py::ruff - pytest_ruff.RuffError: setuptools/config/pyprojecttoml.py:19:1: UP035 [*] Import from `collections.abc` instead: `Mapping`
FAILED setuptools/command/editable_wheel.py::ruff - pytest_ruff.RuffError: setuptools/command/editable_wheel.py:26:1: UP035 [*] Import from `collections.abc` instead: `Iterable`, `Iterator`, `Ma...
FAILED setuptools/monkey.py::ruff - pytest_ruff.RuffError: setuptools/monkey.py:11:1: UP035 `typing.Type` is deprecated, use `type` instead
FAILED setuptools/command/_requirestxt.py::ruff - pytest_ruff.RuffError: setuptools/command/_requirestxt.py:15:1: UP035 [*] Import from `collections.abc` instead: `Mapping`
FAILED setuptools/_reqs.py::ruff - pytest_ruff.RuffError: setuptools/_reqs.py:4:1: UP035 [*] Import from `collections.abc` instead: `Iterable`, `Iterator`
FAILED setuptools/config/setupcfg.py::ruff - pytest_ruff.RuffError: setuptools/config/setupcfg.py:19:1: UP035 [*] Import from `collections.abc` instead: `Iterable`, `Iterator`
FAILED setuptools/build_meta.py::ruff - pytest_ruff.RuffError: setuptools/build_meta.py:41:1: UP035 [*] Import from `collections.abc` instead: `Iterable`, `Iterator`, `Mapping`
FAILED setuptools/config/_apply_pyprojecttoml.py::ruff - pytest_ruff.RuffError: setuptools/config/_apply_pyprojecttoml.py:20:1: UP035 [*] Import from `collections.abc` instead: `Mapping`
FAILED setuptools/discovery.py::ruff - pytest_ruff.RuffError: setuptools/discovery.py:48:1: UP035 [*] Import from `collections.abc` instead: `Iterable`, `Mapping`
FAILED setuptools/command/bdist_wheel.py::ruff - pytest_ruff.RuffError: setuptools/command/bdist_wheel.py:21:1: UP035 [*] Import from `collections.abc` instead: `Iterable`, `Sequence`
FAILED setuptools/dist.py::ruff - pytest_ruff.RuffError: setuptools/dist.py:12:1: UP035 [*] Import from `collections.abc` instead: `MutableMapping`, `Sequence`
FAILED setuptools/command/build_ext.py::ruff - pytest_ruff.RuffError: setuptools/command/build_ext.py:9:1: UP035 [*] Import from `collections.abc` instead: `Iterator`
FAILED setuptools/command/build_py.py::ruff - pytest_ruff.RuffError: setuptools/command/build_py.py:11:1: UP035 [*] Import from `collections.abc` instead: `Iterable`, `Iterator`
FAILED setuptools/tests/config/test_setupcfg.py::TestMetadata::test_warn_dash_deprecation - Failed: DID NOT WARN. No warnings of type (<class 'setuptools.warnings.SetuptoolsDeprecationWarning'>,) were emitted.
FAILED setuptools/tests/config/test_setupcfg.py::TestMetadata::test_make_option_lowercase - Failed: DID NOT WARN. No warnings of type (<class 'setuptools.warnings.SetuptoolsDeprecationWarning'>,) were emitted.
FAILED setuptools/tests/test_dist.py::test_check_specifier - Failed: DID NOT RAISE <class 'distutils.errors.DistutilsSetupError'>
FAILED pkg_resources/__init__.py::ruff - pytest_ruff.RuffError: pkg_resources/__init__.py:54:1: UP035 [*] Import from `collections.abc` instead: `Iterable`, `Iterator`, `Mapping`, `Mu...
FAILED setuptools/tests/test_wheel.py::ruff::format - pytest_ruff.RuffError: File would be reformatted
FAILED setuptools/warnings.py::ruff - pytest_ruff.RuffError: setuptools/warnings.py:15:1: UP035 `typing.Tuple` is deprecated, use `tuple` instead
FAILED setuptools/wheel.py::ruff - pytest_ruff.RuffError: setuptools/wheel.py:34:21: UP033 [*] Use `@functools.cache` instead of `@functools.lru_cache(maxsize=None)`
FAILED tools/generate_validation_code.py::ruff - pytest_ruff.RuffError: tools/generate_validation_code.py:7:1: UP035 [*] Import from `collections.abc` instead: `Iterable`

@jaraco
Copy link
Member Author

jaraco commented Mar 11, 2025

Although tests are now passing for me locally, they're failing in CI. And since I no longer have Python 3.8 available to me on my local machine (I'm guessing Homebrew deleted it), that makes things even more difficult.

@jaraco
Copy link
Member Author

jaraco commented Mar 11, 2025

A lot has changed since October, including the bump of ubuntu-latest, so it's probably not worth getting the CI to run again. If we can get tests to run on Python 3.8, I may just punt on getting CI to work and cut a release manually.

@jaraco
Copy link
Member Author

jaraco commented Mar 11, 2025

I've confirmed that tests mostly pass on Python 3.8, with a few exceptions where the tests attempt to install Setuptools from GitHub and fail because that version is no longer compatible. So I'm going to just force this release through.

I'm going to tag the latest commit as v75.3.1, manually release it, and manually merge it back into main, resolving the conflicts and closing this PR.

@jaraco
Copy link
Member Author

jaraco commented Mar 11, 2025

That's weird. I merged these changes back into main, so I expected this PR to close, but it didn't.

Well, shoot. It's because I neglected to release the whole thing (I omitted 0985ba9 from the merge and the release). Time for one more release.

@jaraco jaraco force-pushed the bugfix/wheel-name-backport branch from 0985ba9 to d5234bd Compare March 12, 2025 00:02
@jaraco jaraco merged commit 84b7b2a into main Mar 12, 2025
6 of 21 checks passed
@jaraco jaraco deleted the bugfix/wheel-name-backport branch March 12, 2025 00:03
@jaraco
Copy link
Member Author

jaraco commented Mar 12, 2025

Since I'd already released v75.3.1 with an incorrect changelog, I cut another release with a fixed changelog v75.3.2. Those changes are now merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backport wheel filename normalization into a Python 3.8 and 3.7 compatible release
1 participant