-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Backport bugfix for wheel naming for Python 3.8 #4879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like I got something wrong in the cherry pick conflict resolution. |
Annoyingly, tests no longer pass on v75.3.0. There are lots of Also, there are some DID NOT WARN failures due to now past due deprecations coming active.
|
Although tests are now passing for me locally, they're failing in CI. And since I no longer have Python 3.8 available to me on my local machine (I'm guessing Homebrew deleted it), that makes things even more difficult. |
A lot has changed since October, including the bump of ubuntu-latest, so it's probably not worth getting the CI to run again. If we can get tests to run on Python 3.8, I may just punt on getting CI to work and cut a release manually. |
I've confirmed that tests mostly pass on Python 3.8, with a few exceptions where the tests attempt to install Setuptools from GitHub and fail because that version is no longer compatible. So I'm going to just force this release through. I'm going to tag the latest commit as v75.3.1, manually release it, and manually merge it back into main, resolving the conflicts and closing this PR. |
That's weird. I merged these changes back into main, so I expected this PR to close, but it didn't. Well, shoot. It's because I neglected to release the whole thing (I omitted 0985ba9 from the merge and the release). Time for one more release. |
0985ba9
to
d5234bd
Compare
Since I'd already released v75.3.1 with an incorrect changelog, I cut another release with a fixed changelog v75.3.2. Those changes are now merged into main. |
Summary of changes
Closes #4877
Pull Request Checklist
newsfragments/
.(See documentation for details)