Support footnotes in Markdown #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From my test on the main branch, the CI has failed already without this change. |
Yes, looks like a recent update to docutils or pygments may have changed the output - would you want to make a separate PR that only updates the test outputs based on current dependencies? |
|
It was Pygments, when I pinned it to v2.18.0, tests passed. maybe we could pin it to 2.18.0 and create a ticket to track and fix it in a future pull request.
sure, will do. |
|
I’ve opened a new PR (#325) to update the test outputs, and all tests are now passing. |
shenxianpeng
force-pushed
the
support-footnotes
branch
from
32db965 to
87cbbdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #323