Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump setuptools from 76.0.0 to 78.1.0 #13310

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 31, 2025

Bumps setuptools from 76.0.0 to 78.1.0.

Changelog

Sourced from setuptools's changelog.

v78.1.0

Features

  • Restore access to _get_vc_env with a warning. (#4874)

v78.0.2

Bugfixes

  • Postponed removals of deprecated dash-separated and uppercase fields in setup.cfg. All packages with deprecated configurations are advised to move before 2026. (#4911)

v78.0.1

Misc

v78.0.0

Bugfixes

  • Reverted distutils changes that broke the monkey patching of command classes. (#4902)

Deprecations and Removals

  • Setuptools no longer accepts options containing uppercase or dash characters in setup.cfg. Please ensure to write the options in setup.cfg using the :wiki:lower_snake_case <Snake_case> convention (e.g. Name => name, install-requires => install_requires). This is a follow-up on deprecations introduced in v54.1.0 <https://setuptools.pypa.io/en/latest/history.html#v54-1-0>_ (see #1608) and v54.1.1 <https://setuptools.pypa.io/en/latest/history.html#v54-1-1>_ (see #2592).

    .. note:: This change does not affect configurations in pyproject.toml (which uses the :wiki:lower-kebab-case <Letter_case#Kebab_case> convention following the precedent set in :pep:517/:pep:518). (#4870)

... (truncated)

Commits

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
setuptools [>= 78.0.dev0, < 78.1]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [setuptools](https://github.com/pypa/setuptools) from 76.0.0 to 78.1.0.
- [Release notes](https://github.com/pypa/setuptools/releases)
- [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst)
- [Commits](pypa/setuptools@v76.0.0...v78.1.0)

---
updated-dependencies:
- dependency-name: setuptools
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Mar 31, 2025
@notatallshaw
Copy link
Member

Is there a way to express to dependabot that it should resolve against the latest version of Python for this file?

importlib-metadata and tomli aren't needed for our build process which uses the latest version of Python:

- uses: actions/setup-python@v5
with:
python-version: "3.x"

https://github.com/pypa/setuptools/blob/6ead555c5fb29bc57fe6105b1bffc163f56fd558/pyproject.toml#L96-L97

@ichard26
Copy link
Member

ichard26 commented Apr 1, 2025

I'd argue that our build environment "lockfile" should include all applicable dependencies so that downstream consumers/users can build pip even on the lowest Python version we still support.

Although where is Dependabot pulling these dependencies from? They are only defined in a core extra.

@notatallshaw
Copy link
Member

I'd argue that our build environment "lockfile" should include all applicable dependencies so that downstream consumers/users can build pip even on the lowest Python version we still support.

Fair enough, but we don't have any tests or validation that will work right now.

In fact, I think this file was generated with a newer Python version and may already not work on older Python versions.

Although where is Dependabot pulling these dependencies from? They are only defined in a core extra.

I think dependabot has the ability to look at a requirements.txt, like this one, and directly update it without context.

@sbidoul

This comment was marked as duplicate.

@sbidoul
Copy link
Member

sbidoul commented Apr 5, 2025

If we don't find a way to tell dependabot to use Python >= 3.12, I guess it's best to simply accept this PR as is.

@notatallshaw
Copy link
Member

notatallshaw commented Apr 5, 2025

It seems we would need to put a ".python-version" file in the root of the repo: dependabot/dependabot-core#1455 (comment)

Unfortunately ".python-version" is used by different tools, and they don't all use it in the same way, so it would apply to more than just this dependency file, depending what tools a contributor may be using, so I don't think it makes sense to add this file.

Some recent discussion: https://discuss.python.org/t/standardize-python-version-file-in-pyproject-toml/86342.

@sbidoul
Copy link
Member

sbidoul commented Apr 5, 2025

However in build-project.py we install all of build-requirements.txt and with recent Python versions, the new requirements added here are not needed at best, and may even be problematic.

I tried pip install -r build-requirements.in -c build-requirements.txt but that does not work due to how --require-hashes is currently implemented.

@notatallshaw
Copy link
Member

However in build-project.py we install all of build-requirements.txt and with recent Python versions, the new requirements added here are not needed at best, and may even be problematic.

Then we should remove the dependabot auto updating:

- package-ecosystem: "pip"
directory: "/"
schedule:
interval: "weekly"

And write a custom github workflow that uses pip-compile.

I tried pip install -r build-requirements.in -c build-requirements.txt but that does not work due to how --require-hashes is currently implemented.

Yeah, you cannot use hashes with constraints, because constraints are designed to work without having to download the full package.

@notatallshaw
Copy link
Member

And write a custom github workflow that uses pip-compile.

Or use uv pip compile --universal to support any Python version ¯\(ツ)

@sbidoul
Copy link
Member

sbidoul commented Apr 6, 2025

We could also move these build files to a subdirectory such as build-project where we add a .python-version and tell dependabot to look there only.

@notatallshaw
Copy link
Member

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 6, 2025

The dependabot.yml entry that created this PR has been deleted so this PR can't be recreated. Please close the PR so Dependabot can create a new one with the current dependabot.yml.

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 6, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/pip/setuptools-78.1.0 branch April 6, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants