-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump setuptools from 76.0.0 to 78.1.0 #13310
Conversation
Bumps [setuptools](https://github.com/pypa/setuptools) from 76.0.0 to 78.1.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst) - [Commits](pypa/setuptools@v76.0.0...v78.1.0) --- updated-dependencies: - dependency-name: setuptools dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Is there a way to express to dependabot that it should resolve against the latest version of Python for this file?
Lines 74 to 76 in 7eb71fa
|
I'd argue that our build environment "lockfile" should include all applicable dependencies so that downstream consumers/users can build pip even on the lowest Python version we still support. Although where is Dependabot pulling these dependencies from? They are only defined in a |
Fair enough, but we don't have any tests or validation that will work right now. In fact, I think this file was generated with a newer Python version and may already not work on older Python versions.
I think dependabot has the ability to look at a requirements.txt, like this one, and directly update it without context. |
This comment was marked as duplicate.
This comment was marked as duplicate.
If we don't find a way to tell dependabot to use Python >= 3.12, I guess it's best to simply accept this PR as is. |
It seems we would need to put a ".python-version" file in the root of the repo: dependabot/dependabot-core#1455 (comment) Unfortunately ".python-version" is used by different tools, and they don't all use it in the same way, so it would apply to more than just this dependency file, depending what tools a contributor may be using, so I don't think it makes sense to add this file. Some recent discussion: https://discuss.python.org/t/standardize-python-version-file-in-pyproject-toml/86342. |
However in I tried |
Then we should remove the dependabot auto updating: Lines 11 to 14 in 06c8024
And write a custom github workflow that uses pip-compile.
Yeah, you cannot use hashes with constraints, because constraints are designed to work without having to download the full package. |
Or use |
We could also move these build files to a subdirectory such as |
@dependabot recreate |
The dependabot.yml entry that created this PR has been deleted so this PR can't be recreated. Please close the PR so Dependabot can create a new one with the current dependabot.yml. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps setuptools from 76.0.0 to 78.1.0.
Changelog
Sourced from setuptools's changelog.
... (truncated)
Commits
6ead555
Bump version: 78.0.2 → 78.1.0d37cd9e
Merge https://github.com/pypa/distutilsefa2eb2
Restore access to _get_vc_env with a warning.3c88de1
Bump version: 78.0.1 → 78.0.2a219451
Revert removals introduced inv78.0.0
(#4911)d4326dd
Allow PyPy to fail on CI.92e22dd
Manually remove file to try to stop flaky tests on PyPycaa48ab
Add news fragment4e9b8ca
Revert removals introduced in v78.0.05450f57
Bump version: 78.0.0 → 78.0.1Most Recent Ignore Conditions Applied to This Pull Request
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)