Skip to content

Fix wheel name normalization in tests #13246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

di
Copy link
Member

@di di commented Feb 26, 2025

Fixes tests with non-normalized filenames that started failing as a result of pypa/setuptools#4766.

@di di added the skip news Does not need a NEWS file entry (eg: trivial changes) label Feb 26, 2025
Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for fixing our tests for us! ❤️

@ichard26 ichard26 merged commit 2feaca9 into pypa:main Feb 26, 2025
28 checks passed
notatallshaw pushed a commit to notatallshaw/pip that referenced this pull request Feb 27, 2025
Setuptools v75.8.1 normalizes the filenames of the wheels it produces in
compliance with a "recent" change in the wheel specification. This also
applies to the .dist-info directories.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants