Avoid coding: utf-8 in Python 3 scripts
#225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
coding_utf-8
branch
from
e8105b7 to
2d37e85
Compare
DimitriPapadopoulos
changed the title
coding: utf-8 in Python 3 scripts
DimitriPapadopoulos
force-pushed
the
coding_utf-8
branch
from
b762194 to
6b761d5
Compare
|
This is not really valid, since you can use installer as library and make it install a wheel into Python 2 environment (in which case, IIRC, the coding info is needed). |
|
If Python 2 target environments are supported, then yes, it's best to keep this as is for non-ASCII module and function names. I may be mistaken, but I cannot find details about support for Python 2 environments in the documentation. |
|
There might not be a mention of that in the docs. No matter that, I would leave the coding comment in place. It doesn't hurt us to keep it there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I know, only Python 3 is supported. Therefore, get rid of
coding: utf-8in generated scripts, as UTF-8 is the default.Also, it could be that
moduleorimport_nameare not ASCII, but then I would rather add tests with non-ASCII module and function names.