Make the {project} placeholder available to repair-wheel-command

[arcondello]

Closes #2588
Closes #1931

Let me know if you'd prefer a different approach for testing, the change I made amounts to a smoke test.

[agriyakhetarpal]

Thanks, @arcondello! This looks good to me. Could you also mark #1931 to be closed with this?

[arcondello]

Oh wow, totally missed that one. Updated

[henryiii]

I'm a little surprised we don't run the command from the project directory on Linux.

[joerick]

I'm a little surprised we don't run the command from the project directory on Linux.

This is what's confusing me also... I'm 90% sure that we do...! But I think this can still be useful so I'm happy to merge it.

On testing, it appears that the previous test did actually assert that the cwd was the project directory previously. Could we make sure that we don't lose that too? It might be best to revert the test change and add another test, perhaps on just a single python version, that runs the script with the {project} placeholder.

[arcondello]

On testing, it appears that the previous test did actually assert that the cwd was the project directory previously. Could we make sure that we don't lose that too? It might be best to revert the test change and add another test, perhaps on just a single python version, that runs the script with the {project} placeholder.

Sure, I can do that

[arcondello]

As an alternative, if the intent is always to run the repair-wheel-command in the project directory, I can change the PR to update the documentation to specify that. IMO the explicit approach gives more flexibility in the future, but I am happy either way.

[joerick]

As an alternative, if the intent is always to run the repair-wheel-command in the project directory, I can change the PR to update the documentation to specify that.

Yes, that is the intention. I doubt that will change - the other commands like before-build etc. also run from the project dir (which is the cwd when cibuildwheel starts). Logic with relative paths gets pretty strange if we change this rule!

Happy to see this noted in the docs.

Also, I think it might be nice for consistency for {package} to be expanded in repair-wheel-command as well. If you have time :)