-
Notifications
You must be signed in to change notification settings - Fork 128
ci: try using tox-uv #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: try using tox-uv #738
Conversation
b03b9bd
to
e8bb33c
Compare
e8bb33c
to
1c02b22
Compare
Perhaps we could try using https://github.com/tox-dev/tox-gh? |
1c02b22
to
e7856f3
Compare
The hope here was to make the tests a bit faster; tox-gh might shorten the config, but wouldn't be faster (AFAIK). I don't understand why one test now uninstalls setuptools when it didn't before when running with tox-uv. |
@@ -68,10 +71,15 @@ jobs: | |||
- name: Setup python for tox | |||
uses: actions/setup-python@v5 | |||
with: | |||
python-version: 3.9 | |||
python-version: 3.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-version: 3.12 | |
python-version: "3.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think this isn't needed anymore, since I changed tox to be installed via uv tool
. Let's check that first.
Interesting, the three failures are: |
Signed-off-by: Henry Schreiner <[email protected]>
581175e
to
609ba2c
Compare
Signed-off-by: Henry Schreiner <[email protected]>
a89afba
to
bbfb1cc
Compare
|
||
|
||
@pytest.mark.skipif('posix_local' not in SCHEME_NAMES, reason='workaround for Debian/Ubuntu Python') | ||
@pytest.mark.skipif('venv' in SCHEME_NAMES, reason='different call if venv is in scheme names') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't venv
always in SCHEME_NAMES
, since 3.11?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this test pass, then?
Lines 346 to 353 in e9adbf0
if 'venv' in scheme_names: | |
# Python distributors with custom default installation scheme can set a | |
# scheme that can't be used to expand the paths in a venv. | |
# This can happen if build itself is not installed in a venv. | |
# The distributors are encouraged to set a "venv" scheme to be used for this. | |
# See https://bugs.python.org/issue45413 | |
# and https://github.com/pypa/virtualenv/issues/2208 | |
paths = sysconfig.get_paths(scheme='venv', vars=config_vars) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(get_paths.assert_called_once_with(scheme='posix_prefix', vars=mocker.ANY
, specifically)
Speeds up CI a little bit. Closes #858.