Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libatomic.so.1 to lib_whitelist #567

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Xeonacid
Copy link

@Xeonacid Xeonacid commented Apr 4, 2025

On RISC-V, GCC 12 and earlier require libatomic support for 1-byte and 2-byte operations, which have been a long and painful story. [1][2][3][4]

Users' machine definitely will have the libatomic library to make software like cpython work, so adding this should be safe.

This seems also to be an regression on cpython 3.13 with more architectures than riscv64. [5]

[1] riscvarchive/riscv-gcc#12
[2] riscvarchive/riscv-gcc#337
[3] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86005
[4] python/cpython#112779
[5] python/cpython#127708

On RISC-V, GCC 12 and earlier require libatomic support for 1-byte and 2-byte operations, which have been a long and painful story. [1][2][3][4]

Users' machine definitely will have the libatomic library to make softwares work, so adding this should be safe.

This seems also to be an regression on cpython 3.13 with more architectures than riscv64. [5]

[1] riscvarchive/riscv-gcc#12
[2] riscvarchive/riscv-gcc#337
[3] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86005
[4] python/cpython#112779
[5] python/cpython#127708
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.37%. Comparing base (8964d1e) to head (aa3c3cc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
- Coverage   92.76%   90.37%   -2.40%     
==========================================
  Files          21       21              
  Lines        1755     1755              
  Branches      331      331              
==========================================
- Hits         1628     1586      -42     
- Misses         77      109      +32     
- Partials       50       60      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant