-
Notifications
You must be signed in to change notification settings - Fork 22
Feat/auto activate emsdk #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add new 'pyodide xbuildenv install-emscripten' command - Add clone_emscripten() method to clone emsdk repository - Add install_emscripten() method to install and activate Emscripten SDK - Add tests for new functionality
for more information, see https://pre-commit.ci
…in test_install_emscripten.py removed as well
for more information, see https://pre-commit.ci
…nd some basic reformatting
1. Changed default version to `get_build_flag("PYODIDE_EMSCRIPTEN_VERSION")`
2. Updated `clone_emscripten` to `_clone_emscripten`
3. Removed and edited redundant tests in both new test files
4. Updated patch path in `xbuildenv.py` and added new command to CI workflow
for more information, see https://pre-commit.ci
Removed the get_build_flag command from xbuildenv cli and added default behavior as none
2. emsdk caching job removed in main.yml 3. install-emscripten help message also edited
2. Fixed pyodide-root to pyodide_root in integration tests
for more information, see https://pre-commit.ci
…4-96 in for clearer test conditions
…int output deleted
for more information, see https://pre-commit.ci
…lready automatically run
|
Thanks for working on this @bulenty584! I have a few comments.
But you don't need to handle (3) in this PR. I am happy to accept this PR with (1) and (2) solved. |
|
Hey @ryanking13 so sorry I haven't been very active as I have had some midterms. I've been looking at the codebase to see how I could directly do #3 you outlined above. My question is exactly what is the problem? My understanding is the user must add relevant Emscripten env vars and adjust their path to point to the new emsdk but I am confused as to how adding emcc to their path achieves the same goal or functionality? Thank you! |
No worries :) We are all volunteers, and each person should work according to their own schedule.
What |
As discussed with @ryanking13, this pr automatically activates emscripten for users (e.g. running source emsdk.sh) and removes the need for them to do it manually. Changes are as follows:
Previous PR was closed due to a branch mistake