Skip to content

Conversation

gselzer
Copy link
Contributor

@gselzer gselzer commented May 7, 2025

Now they can be seen with a dark theme!
image

For reference, here's how it looked before:
image

Now they can be seen with a dark theme!
@gselzer gselzer marked this pull request as draft May 7, 2025 21:43
@gselzer gselzer requested a review from tlambert03 May 7, 2025 21:43
@codecov
Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.93%. Comparing base (35aa5b3) to head (62bc1a7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   78.90%   78.93%   +0.02%     
==========================================
  Files          21       21              
  Lines        1555     1557       +2     
==========================================
+ Hits         1227     1229       +2     
  Misses        328      328              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gselzer
Copy link
Contributor Author

gselzer commented May 7, 2025

Note that this is related to #48 - @fdrgsp what's the state of that PR?

@tlambert03
Copy link
Member

I probably put the cooling on that PR, since theming in general is a slippery slope and I'm hesitate to add anything hardcoded. But I agree it should at least be visible on dark themes, by whatever means (short term or not). Thanks for this! Will look soon

@tlambert03
Copy link
Member

I'm happy to merge this as is. But it's still marked as draft. Are you indeed still wanting to do more work on it?

@gselzer
Copy link
Contributor Author

gselzer commented May 7, 2025

No, no more work needed. I left it as a draft to remind myself to check in on how this relates to #48, but from what you say it seems like that PR shouldn't hold up merge here

@gselzer gselzer marked this pull request as ready for review May 7, 2025 22:10
@tlambert03
Copy link
Member

yeah, my main issue with #48 would be stuff like this ... using the palette is totally fine though

@tlambert03 tlambert03 merged commit 224925c into pymmcore-plus:main May 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants