Clearer explanation of how lift tests are implemented behind the scenes in existing lift test notebook #2061
+139
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
juanitorduz
reviewed
Nov 5, 2025
| "3. You are experimenting with discounts or promotions. These might be quantifiable, but not show up in your traditional media spend channels and so your experimentation may not be captured by your MMM.\n", | ||
| "\n", | ||
| "These are just a few examples where lift tests can be useful. In these cases, you can use the results of the lift test to adjust the model parameters and improve the accuracy of the model.\n", | ||
| "\n", |
Collaborator
There was a problem hiding this comment.
@williambdean , just to confirm. Do we need to scale the lift data? Also, a review from you would be much appreciated :)
Reply via ReviewNB
Contributor
There was a problem hiding this comment.
We are using the multidimensional API already in the notebook, we should not need scaling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Description
Updates to an existing notebook. Focus is on clarifying how lift tests are implemented behind the utility function
add_lift_test_measurements.Checklist
pre-commit.ci autofixto auto-fix.📚 Documentation preview 📚: https://pymc-marketing--2061.org.readthedocs.build/en/2061/