Migrate testimonials page to clients page #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OriolAbril
approved these changes
Oct 27, 2020
|
@OriolAbril ok, no problemo! |
|
Very cool, thanks for the quick turn-around! |
|
Yes, that's right, it's changed to |
|
Though I'm noticing that the Akiri logo is down. |
|
maybe because of the name which is akilii not akili.
…On Wed, Oct 28, 2020, 00:27 Eric Ma ***@***.***> wrote:
Though I'm noticing that the Akiri logo is down.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFETGAMS4YIK75TSPE6U7LSM5JNVANCNFSM4TBQLIPQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20.
This was a bit harder than I had originally anticipated, but managed to get it to work.
I have used Card Columns as the layout format. Gives us a Pintrest-like view over clients. If testimonial is provided, they are shown, otherwise just logos.
Logos have a 10 px border around them added in programmatically by CSS. This helps; previously, the logos were touching the card borders directly.